Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance the error messages #78

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Fix and enhance the error messages #78

merged 8 commits into from
Nov 20, 2023

Conversation

dqhntt
Copy link
Contributor

@dqhntt dqhntt commented Nov 19, 2023

Description

Improve the error messages along with some minor changes. 😊

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have added sufficient documentation in the code

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe48b1b) 100.00% compared to head (9f2cb5c) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           58        57    -1     
  Branches         3         3           
=========================================
- Hits            58        57    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-olivier martin-olivier added the enhancement New feature or request label Nov 19, 2023
@martin-olivier
Copy link
Owner

Hello @dqhntt,

Thank you for your pull request, the overall code and doc are cleaner now :)

If you have some time, can you share your opinion on this other pull request: #71 ?

BR

@martin-olivier martin-olivier merged commit d848a2f into martin-olivier:main Nov 20, 2023
18 checks passed
@martin-olivier martin-olivier removed their request for review November 20, 2023 14:53
@dqhntt
Copy link
Contributor Author

dqhntt commented Nov 21, 2023

Hello @dqhntt,

Thank you for your pull request, the overall code and doc are cleaner now :)

If you have some time, can you share your opinion on this other pull request: #71 ?

BR

Hey @martin-olivier,

Glad you liked it! 😊

While I’d love to take a look, I’m afraid I’m not familiar with developing on Windows enough to offer my opinions on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants