Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepupdate change recursion to loop #625

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lucasfcnunes
Copy link

Solves RecursionErrors exceptions/crashes caused by bloated memory use or high recursion depth when calling deepupdate().
*The same issues can occur on copy.deepcopy() calls.

Solves RecursionErrors exceptions/crashes caused by bloated memory use or high recursion depth when calling deepupdate().
*The same issues can occur on copy.deepcopy() calls.
@lafrech
Copy link
Member

lafrech commented Jan 12, 2021

Do you have a real life use case where the update process significantly eats up the memory to a point where the app crashes?

Or is this more of a theoretical issue?

@lucasfcnunes
Copy link
Author

oh, i did.
at the time of this commit i was actually facing this issue

i was recursively building an api spec using a web scraping engine
i tried running it on a new async thread to tweak the python stack parameters, but i ended up having real seg faults/core dumps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants