Skip to content

Commit

Permalink
Fix GitHub Actions test workflow against outdated Node.js version
Browse files Browse the repository at this point in the history
  • Loading branch information
yhatt committed Oct 28, 2023
1 parent 430ed26 commit ce2df3c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/github-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
github-release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
if: github.event_name == 'push'

- uses: marp-team/actions@v1
Expand All @@ -37,9 +37,9 @@ jobs:
- macOS-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
- name: Install yarn
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/test-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,18 @@ jobs:
node-version:
- '^16.18.1'
- '18.18.0'
include:
- node-version: '^16.18.1'
force: true

steps:
# - name: Output concurrency group
# run: echo "${{ github.workflow }}-${{ (github.ref_name == 'main' && github.run_id) || format('{0}-{1}', github.actor, github.head_ref || github.ref_name) }}"

- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -50,7 +53,7 @@ jobs:
yarn_cache-${{ runner.os }}-
- name: Install dependencies with yarn
run: yarn install --frozen-lockfile
run: yarn install --frozen-lockfile ${{ matrix.force && '--ignore-engines' || '' }}

# Retry tests up to 3 times due to flaky tests on Windows CI
# https://stackoverflow.com/a/59365905
Expand Down

0 comments on commit ce2df3c

Please sign in to comment.