Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change append status when zipping files #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to change append status when zipping files #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions Zip/Zip.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,23 @@ public enum ZipCompression: Int {
}
}

public enum AppendStatus {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some describing documentation to each case describing to the user what it does?

case create
case createAfter
case addinZip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this addInZip instead? As we Add In Zip, right?


internal var minizipStatus: Int32 {
switch self {
case .create:
return APPEND_STATUS_CREATE
case .createAfter:
return APPEND_STATUS_CREATEAFTER
case .addinZip:
return APPEND_STATUS_ADDINZIP
}
}
}

/// Zip class
public class Zip {

Expand Down Expand Up @@ -262,7 +279,7 @@ public class Zip {

- notes: Supports implicit progress composition
*/
public class func zipFiles(paths: [URL], zipFilePath: URL, password: String?, compression: ZipCompression = .DefaultCompression, progress: ((_ progress: Double) -> ())?) throws {
public class func zipFiles(paths: [URL], zipFilePath: URL, password: String?, compression: ZipCompression = .DefaultCompression, appendStatus: AppendStatus = .create, progress: ((_ progress: Double) -> ())?) throws {

// File manager
let fileManager = FileManager.default
Expand Down Expand Up @@ -298,7 +315,7 @@ public class Zip {
progressTracker.kind = ProgressKind.file

// Begin Zipping
let zip = zipOpen(destinationPath, APPEND_STATUS_CREATE)
let zip = zipOpen(destinationPath, appendStatus.minizipStatus)
for path in processedPaths {
let filePath = path.filePath()
var isDirectory: ObjCBool = false
Expand Down