Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated props #9789

Merged
merged 24 commits into from May 3, 2024
Merged

Remove deprecated props #9789

merged 24 commits into from May 3, 2024

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Apr 22, 2024

Problem

Some props are deprecated

Solution

Remove them

TODO

Remove:

  • disableNotification from useCheckAuth
  • disableNotification from useLogoutIfAccessDenied
  • resource from useDeleteWithConfirmController
  • resource from useDeleteWithUndoController
  • data from CreateControllerResult
  • referenceSource from useReferenceInputController
  • saving from SaveContextValue ? 🤔 -> later
  • useGetValidationErrorMessage ? 🤔 -> later
    • <ArrayInput> has to be adapted
  • useLocale
  • useSetLocale
  • linkToRecord
  • resolveRedirectTo
  • onError type from ra-core type.ts
  • formClassName from FieldProps
  • fullWidth from FieldProps
    • many occurences
  • PublicFieldProps from FieldProps
  • InjectedFieldProps from FieldProps
  • formClassName from CommonInputProps
  • sidebarIsOpen from DashboardMenuItem -> later
    • check the impact in ra-no-code before
  • sidebarIsOpen from MenuItemLink -> later
    • check the impact in ra-no-code before
  • rowStyle from Datagrid
  • PaginationLimit
  • rowStyle from SimpleList
  • theme from ThemeProvider

Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good!

docs/Upgrade.md Outdated Show resolved Hide resolved
docs/Upgrade.md Outdated Show resolved Hide resolved
docs/Upgrade.md Outdated Show resolved Hide resolved
docs/Upgrade.md Outdated Show resolved Hide resolved
Co-authored-by: Francois Zaninotto <[email protected]>
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good so far

@fzaninotto
Copy link
Member

I think we can de-deprecate and keep in v5 the following hooks

  • useLocale
  • useSetLocale

@djhi djhi merged commit 9e176fc into next May 3, 2024
12 checks passed
@djhi djhi deleted the chore/remove-deprecated-props branch May 3, 2024 07:21
@fzaninotto fzaninotto added this to the 5.0.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants