Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sanitizing __ types #5243

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

maximgeerinck
Copy link

When using graphql, we rely on __typename for identifying the correct types in a union type.

imagine i have the following interface

interface Animal {
    id: ID!
}

type Crawler implements Animal {
    legs: Int
}

type Swimmer implements Animal {
    fins: Int
}

we would return a type of the form union SomeAnimal = Crawler & Swimmer where we rely on __typename to correctly display some information on the dashboard.

With this proposal I ask to not filter out __ fields.

When using graphql, we rely on `__typename` for identifying the correct types in a `union` type.

imagine i have the following interface

```
interface Animal {
    id: ID!
}

type Crawler implements Animal {
    legs: Int
}

type Swimmer implements Animal {
    fins: Int
}
```

we would return a type of the form `union SomeAnimal = Crawler & Swimmer` where we rely on `__typename` to correctly display some information on the dashboard.

With this proposal I ask to not filter out `__` fields.
@fzaninotto fzaninotto changed the base branch from master to 3.x April 12, 2022 16:45
@fzaninotto fzaninotto added the v3 label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants