fix: ReferenceArrayInput might pass non-array to children as values #4874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when you use multiple Filters using the same resource (or a sub-property) and one uses a
ReferenceArrayInput
, it might receive its value from another filter. When this is not an array, it will crash, at it will assume that the value is an array.E.g. consider these filters:
the second one will receive a value of
{ school: { id: "some-schoolId", ...}}
and therefore crashThe quickfix is to define a format, altough this is not so obvious.
I think it makes sense to define that as default for
ReferenceArrayInput
as they assume that if they have a non-falsy value, it is an array.