Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll buttons to tabs when they go beyond the available space #4538

Merged
merged 18 commits into from Aug 3, 2020
Merged

Add scroll buttons to tabs when they go beyond the available space #4538

merged 18 commits into from Aug 3, 2020

Conversation

JulienMattiussi
Copy link
Contributor

@JulienMattiussi JulienMattiussi commented Mar 16, 2020 •
edited

Closes #1689

Issue

A lot of tabs in TabbedForm or TabbedShow make all page wide and scrollable instead of using scrolling tab buttons.

Solution

Enable scrollable tabs by default, and add a prop to keep possibility to disable it

<TabbedForm
   scrollable={false}
>

Screenshots

image

@JulienMattiussi JulienMattiussi added WIP Work In Progress RFR Ready For Review and removed WIP Work In Progress labels Mar 16, 2020
djhi
djhi requested changes Mar 17, 2020
View reviewed changes
docs/CreateEdit.md Outdated Show resolved Hide resolved
docs/Show.md Outdated Show resolved Hide resolved
@jdemangeon
Copy link
Contributor

Sadly, tests are failing :(

Base automatically changed from next to master June 5, 2020 14:24
Luwangel
Luwangel suggested changes Jul 31, 2020
View reviewed changes
docs/CreateEdit.md Outdated Show resolved Hide resolved
docs/Show.md Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/detail/TabbedShowLayout.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/detail/TabbedShowLayout.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/form/TabbedForm.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/form/TabbedForm.js Outdated Show resolved Hide resolved
@JulienMattiussi JulienMattiussi changed the base branch from master to next August 3, 2020 14:40
@Luwangel Luwangel added this to the 3.8.0 milestone Aug 3, 2020
@Luwangel Luwangel merged commit 55b8721 into next Aug 3, 2020
@Luwangel Luwangel deleted the too-much-tabs branch August 3, 2020 15:31
@fzaninotto fzaninotto restored the too-much-tabs branch August 11, 2020 09:06
@fzaninotto fzaninotto deleted the too-much-tabs branch August 11, 2020 09:06
@fzaninotto
Copy link
Member

I have to revert that change as it breaks TabbedForm

image

fzaninotto added a commit that referenced this pull request Aug 11, 2020
@fzaninotto
Revert Add scroll buttons to tabs when they go beyond the available s…
7557bf2 
…pace

Refs #4538
This was referenced Aug 11, 2020
Merged
Closed
@fzaninotto fzaninotto removed this from the 3.8.0 milestone Aug 11, 2020
@fzaninotto
Copy link
Member

Reverted in #5132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi requested changes

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A lot of tabs shows scrollbar and crashes the application
5 participants
@JulienMattiussi @jdemangeon @fzaninotto @djhi @Luwangel