Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeblock indent rnw pr #3298

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rnwelsh
Copy link

@rnwelsh rnwelsh commented Jun 9, 2022

Q A
Bug fix? yes
New feature? no
Breaking changes? no
Deprecations? no
New tests added? not needed
Fixed tickets #3273
License MIT

inserts \u0020 (Space) instead of \u00a0 (NBSP) with tab key

Inserting the NBSP character from tabs causes bugs when copying code from a codeblock in certain environments. The specific issue I encountered was with Oracle Database, where the NBSP is not interchangeable with a space character.

Q A
Bug fix? yes
New feature? yes
Breaking changes? no
Deprecations? no
New tests added? not needed
Fixed tickets #2427
License MIT

Maintain indentation within codeblocks

With a minor adjustment to the regex for detecting indentation within codeblocks, indentation level is maintained on the next line. I also included an update so that backspace decreases indentation when the cursor is directly behind at least a tabWidth of whitespace, and a range is not selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant