Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom CSS Support #3279

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

changbowen
Copy link

Q A
Bug fix? no
New feature? yes
Breaking changes? no
Deprecations? no
New tests added? not needed / need help
Fixed tickets Fixes #174
License MIT

Description

Adds a text area under Themes setting for specifying arbitrary CSS content that will be applied on top of the current theme. The text area might need more work on its appearance. Also doesn't affect exports as I was not sure how that should work.
image

Works fine with my limited testing.

I don't have much experience with Electron apps and this was a fun experience... This is just my two cents and feel free to make any changes. Apologies if the pull request is mal-formatted or any mandatory steps are missed.

Jocs and others added 5 commits March 28, 2020 12:49
* update readme (marktext#2008)

* update readme

* remove unused codes

* Update third party

* remove unused codes

* fix: style error in editor setting

* Release v0.16.1 (marktext#2011)
* update readme (marktext#2008)

* update readme

* remove unused codes

* Update third party

* remove unused codes

* fix: style error in editor setting

* Release v0.16.1 (marktext#2011)

* Fix typo (marktext#2118)

* Include Chocolatey package installation option (marktext#2107)

* Update dependencies (marktext#2133)

* Fix max width of editor tabs (marktext#2097)

* Fix max width of editor tabs

* Update sponsor (marktext#2141)

* update: sponsors

* update img width and height

* Add ability to paste images to Features (marktext#2127)

* Fix empty shortcuts in shortcut validator (marktext#2130)

* Fix Hunspell dictionary downloader on Windows (marktext#2131)

* Add missing encoding entry (marktext#2132)

* Improve heading font size scaling (marktext#2135)

* Reduce dependency bundle size (marktext#2136)

* Fix Hunspell spell checker initialization on Windows (marktext#2137)

* Disable and hide unnecessary settings options (marktext#2138)

* Increase indentation for sidebar treeview (marktext#2161)

* Fix image export issues on Windows (marktext#2129)

* Fix footnote renderer exception in markedjs (marktext#2162)

* Add GitLab math block support (marktext#2119)

* update: yarn.lock file (marktext#2178)

* feat: switch tabs using alt-#num (marktext#1975)

* Fix bad font when exporting document on macOS (marktext#2190)

* 📝 update zh_cn.md (marktext#2192)

* Improve English grammar in user-interface text. (marktext#2075)

* Fix unnecessary character sanitation on clipboard output (marktext#2197)

* Fix double used shortcut (marktext#2198)

* Fix double used shortcut

* Update documentation

* Update dependencies (marktext#2199)

* Support setting text direction via comand palette (marktext#2194) (marktext#2195)

* Update bug issue template (marktext#2215)

* Fix inline html renderer (marktext#2224)

* Fix sub- and superscript in HTML output

* Update dependencies

* Conform user-interface text to conventions for trailing punctuation (marktext#2209)

* Release v0.16.2 (marktext#2200)

Bump version to 0.16.2 and update documentation.

* Replace PRC emoji for zh_TW translation with Taiwan flag (marktext#2278)

* Update FAQ.md (marktext#2290)

Clarify what aidou is for non-chinese users

* Fix markdown syntax document mistake for table content align (marktext#2282) (marktext#2296)

* Update pt.md (marktext#2350)

* Update pt.md

My annual contribution to Mark Text, with its documentation accessible to all Brazilians and Portuguese.

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update regex of auto link to fix trailing slashes (marktext#2354)

* Update FAQ.md - link to Portable (marktext#2337)

Fixing link to portable page.

* updated turkish translation of readme.md (marktext#2366)

* pass file.id to closeTab on middle click (marktext#2272)

* Add codeblock highlight and coloration for the SPARQL and Turtle languages (marktext#2365)

* fix image paths on readme tr.md (marktext#2374)

* Fix issue with not being able to copy table cell (marktext#2375)

* fixed issue#2383 (marktext#2397)

* Fix quick open bug and freeze constants to avoid accidental mutation (marktext#2323)

* fix: marktext#2330 enable shift+tab for table navigation (marktext#2331)

* fix: prism language missing while load dependent language (marktext#1752) (marktext#2335)

* Fix graphite light wordcount (marktext#2392)

* Update dependencies (minor only) (marktext#2402)

* fix: typewriter shake after press enter (marktext#1852)

* Support negative zoom (marktext#2412)

* Restrict export dialog file extensions (marktext#2408)

* Allow BCP-47 language codes in spell checker (marktext#2410)

* Fix footnote inline code font size (marktext#2411)

* feat: add shortcut for toggle-toc (marktext#1863) (marktext#2326)

* Make global menu fields mutable (marktext#2407)

* Replace text when only one table cell is selected (marktext#2413)

* Allow to copy table cells text as plaintext (marktext#2409)

* Fix font selection autocomplete (marktext#2420)

* Updated korean translation of README.md (marktext#2432)

I updated ko.md (korean translation of README.md) to match the latest version of README.md

* Rebase markedjs bug fixes (marktext#2419)

* Add option to disable HTML rendering (marktext#2414)

* Fix symbolic links and related path issues (marktext#2416)

* Upgrade to N-API and Electron 11 (marktext#2422)

* Upgrade to N-API and Electron 11

* Update Electron and remove workaround

* Fix ESLint error

* Disble MathML due to DOMPurify security issues (marktext#2436)

* Update Simplified Chinese translation of README (marktext#2445)

* Improve undo history (marktext#2437)

* Add TOC generator to document exporter (marktext#2391)

* Add support for relative image directory (marktext#2439)

* Fix installation instructions in README.md (marktext#2449)

* Update README.md

Calling brew cask install is disabled

* Update i18n files

* Release v0.16.3 (marktext#2448)

Co-authored-by: Ran Luo <[email protected]>
Co-authored-by: saymoon <[email protected]>
Co-authored-by: shaunmbg <[email protected]>
Co-authored-by: Micael Dias <[email protected]>
Co-authored-by: Dan Dascalescu <[email protected]>
Co-authored-by: BeatLink <[email protected]>
Co-authored-by: He Linming <[email protected]>
Co-authored-by: Royce <[email protected]>
Co-authored-by: brainchild0 <[email protected]>
Co-authored-by: Rasmus Eneman <[email protected]>
Co-authored-by: nyanpasu64 <[email protected]>
Co-authored-by: Sbelletier <[email protected]>
Co-authored-by: 小新 <[email protected]>
Co-authored-by: Enderson Menezes <[email protected]>
Co-authored-by: Sweet Liquid <[email protected]>
Co-authored-by: Nick Ali <[email protected]>
Co-authored-by: erentar <[email protected]>
Co-authored-by: Max Lantas <[email protected]>
Co-authored-by: Vincent Emonet <[email protected]>
Co-authored-by: Amauri Bizerra <[email protected]>
Co-authored-by: Anton Freeman <[email protected]>
Co-authored-by: Dan Munckton <[email protected]>
Co-authored-by: evan-cohen <[email protected]>
Co-authored-by: zmen <[email protected]>
Co-authored-by: bmvisoky <[email protected]>
Co-authored-by: YeloMelon <[email protected]>
Co-authored-by: MingZZX <[email protected]>
Co-authored-by: カワリミ人形 <[email protected]>
@Paquereauman
Copy link

Super I will try it tomorrow

@Paquereauman
Copy link

Is there a file in which i can modiy dirextly the css for hearders? and else ?

@Paquereauman
Copy link

Ok so I don't know tat much how to merge it with my app

I was not even successful to find the folder them/export on kde distribution, to change directly the css.

Is there any help x)

@changbowen
Copy link
Author

Sorry I don't understand.. @Paquereauman is it related to the changes I made in this pull request?

@Paquereauman
Copy link

Sorry I don't understand.. @Paquereauman is it related to the changes I made in this pull request?
I guess wrong place, my statements would have been fitting better in "issues" ? right. I was tring to figure out how to change the css and I have been looking at in the directory file in home/config/marktext without success.

So If I understood it well this is an upgrade to test before to merge ? I was also trying to test it but same I don't find the good directory to replace the 7 files.

@changbowen
Copy link
Author

If you want to test the changes, clone the custom-css branch here and build it locally. Then you can run the built executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customize theme(css styles) in Mark Text
4 participants