Add pylint #251
Add pylint #251
Conversation
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 91.05% 90.14% -0.91%
==========================================
Files 46 46
Lines 2739 2609 -130
==========================================
- Hits 2494 2352 -142
- Misses 245 257 +12
Continue to review full report at Codecov.
|
| @@ -1,7 +1,9 @@ | |||
| FROM python:3.6-alpine | |||
|
|
|||
| RUN mkdir /src \ | |||
| && mkdir /tool | |||
| && mkdir /tool \ | |||
| && apk add musl-dev gcc \ | |||
There was a problem hiding this comment.
Does pylint have native extensions?
There was a problem hiding this comment.
Are you asking if there are more dependencies that are required here? Pylint does have a concept of an "extension", but I don't see any that require external libraries.
There was a problem hiding this comment.
If there are no additional dependencies why do you need musl-dev and gcc?
| output = output.split("\n") | ||
| output = [line for line in output if not line.startswith("*********")] | ||
| def make_command(self, files): | ||
| self.check_options() |
There was a problem hiding this comment.
The py3k tool needs to remove the python option as pylint --py3k doesn't do anything useful in python3.
There was a problem hiding this comment.
Good catch, updated here: 61d75fb
This adds full pylint functionality to lint-review.