Add feed reader initial implementation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I prefer to use factory functions instead.
Started to clean up templates for feed categories.
- Feed categories render similar to projects - categories need some schema changes. Slug and unread_item_count which could be inferred from the subscription unread count.
Need a few more columns to track which post is which and what the URLs are
- build out feed view some more. - build out links to source page. - add janky refresh action
Also fix delete confirm dialogs not being closeable.
It was impossible to use before.
Instead of a management UI for subscriptions being the first page, reading should be the focus
I wasn't handling protocol relative URLs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
============================================
+ Coverage 91.84% 91.98% +0.14%
- Complexity 714 850 +136
============================================
Files 152 169 +17
Lines 7782 8560 +778
============================================
+ Hits 7147 7874 +727
- Misses 635 686 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Trying not to be lazy and baseline everything.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mostly working feed reader with basic categories, feed management and reading flows.
There is no automatic syncing yet, and all syncing needs to be done manually. In the future, automatic syncing will be added via commands that can be automated with cron or queues.