Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ViktorLindgren95
Copy link

Hello i updated the Readme to refer to the action correctly. you also have version v5 and not v1 anymore, alternatively you can refer to a brain such as @main but that is not best practice.

There is another part i dont know how to really document as i just started playing with this action today. but the firstHeadingPageTitle option should be commented somewhere for this action as its super useful for people. I found it by looking around documentation for other stuff inside this project. I would recommend that you add a short explanation to the project for it.

Updated the readme to reference the github action correctly
@ViktorLindgren95
Copy link
Author

I just noted that an input field for firstHeadingPageTitle dosent exist but is supported inside the .markdown-confluence.json file.

@petitcl
Copy link

petitcl commented Mar 6, 2024

Hey! I was also affected by this and it took me lot of time to understand that the example was not accurate. Can we merge this PR so that nobody else is affected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants