This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Issue: Word-wrap requires two render cycles #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 171ef32. It has some calls to methods that don't yet exist- making Box's fill behavior optional. This allows it to be used for layout as well as styling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure I'd commented on this previously, but hadn't been able to come up with a good example- here is one.
When a
Labelhas wordwrap enabled, it isn't able to compute itsSizeHintuntil it has an initial Size (for its width). However, when embedded in e.g.Box, it means the initial sizing isn't accurate- it gets cut off until it's resized again, at which point theSizeHintis accurate.This just demonstrates the issue without actually fixing it. :-(
(This is rebased on top of #105 because it was easier for me to see the blank lines that way.)