replace majority of boost->std optional and boost->std string_view #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathisloge
commented
Apr 19, 2024
mathisloge
commented
May 13, 2024
mathisloge
force-pushed
the
feature/drop_boost_cpp17
branch
from
3b87b5a
to
e184b09
Compare
mathisloge
force-pushed
the
feature/drop_boost_cpp17
branch
from
e184b09
to
21276ab
Compare
|
@artemp There are some missing bits, where the optional value type has a reference type. I would do these in a seperate PR, as depending on the approch taken, would be a bit more code change then just renaming. |
|
@artemp could you review this? |
artemp
approved these changes
May 22, 2024
|
@mathisloge looks good, going to merge! |
|
|
Yeah, that would be one way, with the least intrusive change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.