Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking error #4425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Nakaner
Copy link
Contributor

@Nakaner Nakaner commented Nov 24, 2023

This pull request uses fixes described in #4243 (comment)

It is an alternative to #4370 but with fewer changes (and addresses the comment by @luk-brue on that pull request.

I can confirm the original bug report on both Arch Linux (same as the reporter) and Ubuntu Jammy.

@artemp artemp self-assigned this Nov 24, 2023
@artemp artemp self-requested a review November 24, 2023 14:35
@Nakaner
Copy link
Contributor Author

Nakaner commented Dec 5, 2023

rebased onto current master branch

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e1b325) 74.12% compared to head (fcdfaeb) 74.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4425   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         493      493           
  Lines       31845    31845           
=======================================
  Hits        23605    23605           
  Misses       8240     8240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants