Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewbox refactor #4373

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Viewbox refactor #4373

wants to merge 7 commits into from

Conversation

artemp
Copy link
Member

@artemp artemp commented Dec 19, 2022

re-factor viewport/viewBox logic to support nested <svg> elements

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 75.00% // Head: 74.94% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (9e96740) compared to base (4e064b8).
Patch coverage: 37.20% of modified lines in pull request are covered.

❗ Current head 9e96740 differs from pull request most recent head d02f6e4. Consider uploading reports for the commit d02f6e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4373      +/-   ##
==========================================
- Coverage   75.00%   74.94%   -0.07%     
==========================================
  Files         524      511      -13     
  Lines       36774    36709      -65     
==========================================
- Hits        27582    27511      -71     
- Misses       9192     9198       +6     
Impacted Files Coverage Δ
include/mapnik/svg/svg_parser.hpp 100.00% <ø> (ø)
...nclude/mapnik/svg/svg_transform_grammar_x3_def.hpp 19.29% <11.11%> (ø)
src/svg/svg_parser.cpp 80.58% <44.11%> (+0.15%) ⬆️
src/datasource_cache_static.cpp 33.33% <0.00%> (-60.96%) ⬇️
plugins/input/pgraster/pgraster_datasource.hpp 0.00% <0.00%> (-50.00%) ⬇️
include/mapnik/expression_evaluator.hpp 54.32% <0.00%> (-28.38%) ⬇️
include/mapnik/debug.hpp 71.01% <0.00%> (-26.82%) ⬇️
include/mapnik/webp_io.hpp 44.21% <0.00%> (-17.56%) ⬇️
src/tiff_reader.cpp 56.25% <0.00%> (-1.75%) ⬇️
plugins/input/geobuf/geobuf_datasource.cpp 68.86% <0.00%> (-0.86%) ⬇️
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant