Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop setting SourceCode attribute #4159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomhughes
Copy link
Contributor

SCons 4 has dropped dropped support for the SourceCode attribute.

SCons 4 has dropped dropped support for the SourceCode attribute.
@lightmare
Copy link
Contributor

lightmare commented Jul 16, 2020

Not knowing what it was for, I found this note in Scons 3 doc:

scons will, by default, fetch files from SCCS or RCS subdirectories without explicit configuration. This takes some extra processing time to search for the necessary source code management files on disk. You can avoid these extra searches and speed up your build a little by disabling these searches as follows:

env.SourceCode('.', None)

I never knew there was such a default. Is that extra search insignificant, or would it be more appropriate to keep fallback for SCons 3? Something like:

if getattr(env, 'SourceCode', None): env.SourceCode('.', None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants