Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and installation instructions #4153

Open
wants to merge 2 commits into
base: v3.0.x
Choose a base branch
from
Open

Add Dockerfile and installation instructions #4153

wants to merge 2 commits into from

Conversation

hiddewie
Copy link

@hiddewie hiddewie commented Jun 14, 2020

Based on https://github.com/jawg/docker-mapnik3 and jawg/docker-mapnik3#8. Usage of Apache licensed software (the image build instructions in this case) should be fine if the Apache License is mentioned explicitly (it is in this PR).

This PR should fix #3704.

Travis integration is still needed: https://docs.travis-ci.com/user/docker/#building-a-docker-image-from-a-dockerfile

The Python and Node bindings could have their own Docker image which also compile those bindings into a derived image.

Each 'main' branch of the project should have it's own image, in particular each release.

@hiddewie hiddewie changed the base branch from master to v3.0.x June 14, 2020 14:33
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #4153 into v3.0.x will decrease coverage by 1.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v3.0.x    #4153      +/-   ##
==========================================
- Coverage   68.96%   67.02%   -1.94%     
==========================================
  Files         446      446              
  Lines       22984    22324     -660     
==========================================
- Hits        15851    14963     -888     
- Misses       7133     7361     +228     
Impacted Files Coverage Δ
include/mapnik/image.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/value.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/params.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/boolean.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/geometry.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/image_any.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/text/face.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/util/trim.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/util/name_to_int.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/mapnik/grid/grid_renderer.hpp 0.00% <0.00%> (-100.00%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8346dd...ec97a02. Read the comment docs.

@hiddewie
Copy link
Author

I have no idea why the code coverage would change for this PR. It does not touch the source or tests.

@Sieboldianus
Copy link

Sieboldianus commented Jul 14, 2022

Based on https://github.com/jawg/docker-mapnik3 and jawg/docker-mapnik3#8. Usage of Apache licensed software (the image build instructions in this case) should be fine if the Apache License is mentioned explicitly (it is in this PR).

This PR should fix #3704.

Travis integration is still needed: https://docs.travis-ci.com/user/docker/#building-a-docker-image-from-a-dockerfile

The Python and Node bindings could have their own Docker image which also compile those bindings into a derived image.

Each 'main' branch of the project should have it's own image, in particular each release.

Many thanks for the Dockerfile. Did you test to include the python-bindings in the Dockerimage? I have tried, but did not suceed so far.

@Sieboldianus
Copy link

Here's a (tested) Dockerfile that adds python-bindings to mapnik3 docker from jawg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official Docker images for Mapnik?
2 participants