PostGIS+PGraster: pass exact floating-point numbers in SQL queries #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table has proper ID and GEOM columns, so it must be usable even though there's no data in it.
ST_MakeEnvelope accepts coordinates as float8 (double precision). Use hexfloat format to pass exact values, avoiding wonky conversion to and from decimal.
lightmare
force-pushed
the
postgis-hexfloat-literals
branch
from
a622111
to
6c2faf3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4089 +/- ##
==========================================
+ Coverage 72.05% 72.07% +0.02%
==========================================
Files 452 453 +1
Lines 24324 24314 -10
==========================================
- Hits 17526 17525 -1
+ Misses 6798 6789 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4079
Refs #2361
Pass floating-point numbers in SQL queries with explicit type cast and in hexfloat format (exact value). Postgres parses floats with
stdtod, which understands hexfloat since C99.On plugin side, I intended to use stream format
std::hexfloat, but to my surprise libstdc++ 4.9 (which clang builds on travis still use) does not implement it (was added in libstdc++ 5.1). In the end, using C99snprintfto produce what's going to be parsed by C99strtodseems like a much better idea.TODO