Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup example assets #524

Merged
merged 33 commits into from
Dec 8, 2024

Conversation

KiwiKilian
Copy link
Collaborator

@KiwiKilian KiwiKilian commented Dec 1, 2024

Improve many examples, reduce assets being used and replace mapbox sources.

# Conflicts:
#	packages/examples/src/App.tsx
#	packages/examples/src/examples/Annotations/CustomCallout.tsx
#	packages/examples/src/examples/FillRasterLayer/IndoorBuilding.tsx
#	packages/examples/src/examples/Map/ShowMap.tsx
#	packages/examples/src/examples/Map/ShowMapLocalStyle.tsx
#	packages/examples/src/examples/SymbolCircleLayer/EarthQuakes.tsx
#	packages/examples/src/utils/index.ts
#	packages/expo-app/app.config.ts
@KiwiKilian KiwiKilian changed the title chore: cleanup more examples chore: cleanup example assets Dec 2, 2024
@KiwiKilian KiwiKilian changed the base branch from main to beta December 2, 2024 10:12
@KiwiKilian KiwiKilian marked this pull request as ready for review December 6, 2024 15:08
@KiwiKilian KiwiKilian requested a review from tyrauber December 6, 2024 15:09
Copy link
Collaborator

@tyrauber tyrauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. The new ~77,000 lines are related to the new json file?

@KiwiKilian
Copy link
Collaborator Author

Yes, because I pretty printed for better understanding, how the data is structured.

@KiwiKilian KiwiKilian merged commit 43b331d into maplibre:beta Dec 8, 2024
13 checks passed
@KiwiKilian KiwiKilian deleted the feat/typescript-examples branch December 8, 2024 17:09
Copy link

github-actions bot commented Dec 8, 2024

🎉 This PR is included in version 10.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants