chore: improve examples monorepo setup with reusable App #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiwiKilian
commented
Oct 24, 2024
# Conflicts: # packages/examples/package.json # packages/examples/src/components/ButtonGroup.tsx # packages/examples/src/styles/colors.ts # packages/expo-app/App.js # packages/expo-app/package.json # packages/react-native-app/package.json # packages/react-native-app/src/App.js # yarn.lock
|
🎉 This PR is included in version 10.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Merge this after #472 – will also make reviewing the changes easier 😄.
Description
I've digged into the monorepo setup and improved the reusability even more. Now the two example app only manage there native dependencies. This way, different
react-nativeversions are possible in the two apps. I've also upgraded the RN example to at least be working with 0.75. Thereby I was also able to heavily reduce thebabel.config.jsandmetro.config.js. Both are pretty much the same with just different import/correct presets.Only bigger difference I see is the dependency to
@maplibre/maplibre-react-nativewhich is necessary on Expo (otherwise I can't build, problems with plugin) but must be avoided on RN (otherwise Android complains about two of the same libraries).Along the way I aligned naming of the projects, added icons, splash screens and renamed the apps. Now better to differentiate through name which app one is using in simulator.
Make sure to purge and clean as much as possible before trying to build. Might also need to run
rm -rf ~/.gradle/caches/– at least I had a few problems midway the migration 😅. But now it seems to build fine for all four variants from clean state and incremental.