Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eslint formatting and improve scripts #467

Merged
merged 13 commits into from
Oct 21, 2024

Conversation

KiwiKilian
Copy link
Collaborator

@KiwiKilian KiwiKilian commented Oct 14, 2024

Description

  • ESLint
    • Is now applied to TS and JS and therefore also Prettier is applied to more files
    • Config separated into .eslintrc.js and scripts/.eslintrc.js
  • Improved some version constraints (we still don't have globally aligned versions of react-native etc...)
  • I've streamlined the scripts section of the package.json

To easily see the actual changes, have a look at the individual commits. The two style commits apply a lot of changes.

Should I create a .git-blame-ignore-revs? It would allow to hide my commit with the auto-fixes from blame.

Also, once again, does this need a changelog entry? It shouldn't contain any user facing changes.

@KiwiKilian KiwiKilian changed the title fix: eslint, formatting and improve scripts chore: eslint formatting and improve scripts Oct 14, 2024
.eslintrc.js Outdated Show resolved Hide resolved
@tyrauber
Copy link
Collaborator

@KiwiKilian, Let's go ahead and add a .git-blame-ignore-revs? file. We should probably have one anyway.

@KiwiKilian
Copy link
Collaborator Author

@tyrauber I've added the .git-blame-ignore-revs.

@KiwiKilian
Copy link
Collaborator Author

For the .git-blame-ignore-revs to work I guess you must NOT squash this when merging?

@KiwiKilian
Copy link
Collaborator Author

@tyrauber I've noticed that tsc linting didn't work for the examples. I've added a tsconfig.json and aligned the others.

@KiwiKilian KiwiKilian requested a review from tyrauber October 21, 2024 15:06
@tyrauber tyrauber merged commit 77701aa into maplibre:main Oct 21, 2024
4 checks passed
@KiwiKilian KiwiKilian deleted the feature/eslint branch October 21, 2024 18:48
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 10.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants