Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typescript errors and add typescript:check to Github CI #418

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix typescript errors and add typescript:check to Github CI #418

merged 1 commit into from
Jul 15, 2024

Conversation

caspg
Copy link
Contributor

@caspg caspg commented Jul 15, 2024

Description

Fixes #416

  • fix typescript errors
  • adds typescript check to the Github actions

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I have run tests via yarn test in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/updated a sample (/example)

Screenshot OR Video

@tyrauber tyrauber merged commit 20cf3be into maplibre:main Jul 15, 2024
4 checks passed
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 10.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript compilation errors when adding this library to a project, v10.0.0-alpha.7
2 participants