ci: use GITHUB_PATH

maplibre · Dec 6, 2024 · ff4993b · ff4993b
1 parent c6238e2
commit ff4993b
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/.github/workflows/review.yml b/.github/workflows/review.yml
@@ -106,7 +106,7 @@ jobs:
 
       - name: Build Android
         working-directory: ./packages/react-native-app
-        run: yarn react-native build-android
+        run: yarn react-native build-android --mode Release
 
   build-react-native-ios:
     name: Build React Native iOS & Test with Maestro
@@ -124,15 +124,21 @@ jobs:
         working-directory: ./packages/react-native-app
         run: |
           curl -Ls "https://get.maestro.mobile.dev" | bash
+          echo "$HOME/.maestro/bin" >> "$GITHUB_PATH"
           brew tap facebook/fb
           brew install facebook/fb/idb-companion
 
+      - name: Maestro Version
+        working-directory: ./packages/react-native-app
+        run: maestro --version
+
       - name: Install Pods
         working-directory: ./packages/react-native-app
         run: yarn pod:install
 
       - name: Build iOS
         working-directory: ./packages/react-native-app
+        # Like `react-native build-ios --mode Release` but adapted for simulators
         run: xcodebuild -workspace ios/MapLibreReactNativeExample.xcworkspace -scheme MapLibreReactNativeExample -configuration Release -sdk iphonesimulator -derivedDataPath ios/build
 
       - name: Install on iOS Simulator
@@ -143,7 +149,4 @@ jobs:
 
       - name: Test with Maestro
         working-directory: ./packages/react-native-app
-        run: |
-          export PATH="$PATH":"$HOME/.maestro/bin"
-          maestro --version
-          maestro test e2e/show-map.yml
+        run: maestro test e2e/show-map.yml