Skip to content

Commit

Permalink
fix: allow MapView and Images to have no children (#521)
Browse files Browse the repository at this point in the history
* fix: allow MapView and Images to have no children
* docs: update changelog
* docs: changelog fixes
  • Loading branch information
KiwiKilian authored Nov 28, 2024
1 parent 5ac603b commit 1e35bf6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
7 changes: 4 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ Please add unreleased changes in the following style:
- PR Title ([#___](https://github.com/maplibre/maplibre-react-native/pull/___))
```

- fix: allow MapView and Images to have no children ([#521](https://github.com/maplibre/maplibre-react-native/pull/521))
- docs: reformat changelog ([#520](https://github.com/maplibre/maplibre-react-native/pull/520))
- refactor: rename `RCTMLN` to `MLRN` ([#519](https://github.com/maplibre/maplibre-react-native/pull/519))
- ci: improve workflows ([#513](https://github.com/maplibre/maplibre-react-native/pull/513))

## 10.0.0-alpha.28

- feat: setup build step ([#504](https://github.com/maplibre/maplibre-react-native/pull/504)
- feat: setup build step ([#504](https://github.com/maplibre/maplibre-react-native/pull/504))

## 10.0.0-alpha.27

Expand Down Expand Up @@ -138,12 +139,12 @@ Please add unreleased changes in the following style:
- fix: Duplicated Signature issue with Xcode 15 ([#238](https://github.com/maplibre/maplibre-react-native/pull/238))
- Update download-style-spec.sh ([#163](https://github.com/maplibre/maplibre-react-native/pull/163))
- Update react-maplibre ([#34](https://github.com/maplibre/maplibre-react-native/issues/34))
- chore: update support libraries ([#121](https://github.com/maplibre/maplibre-react-native/pull/121)).
- chore: update support libraries ([#121](https://github.com/maplibre/maplibre-react-native/pull/121))
- fix: correct types in MapView ([#268])(https://github.com/maplibre/maplibre-react-native/pull/268))

## 10.0.0-alpha.1

- fix: plugin for debug simulator ([#164](https://github.com/maplibre/maplibre-react-native/pull/164)
- fix: plugin for debug simulator ([#164](https://github.com/maplibre/maplibre-react-native/pull/164))

## 10.0-alpha.0

Expand Down
4 changes: 3 additions & 1 deletion src/components/Images.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,10 @@ interface ImagesProps extends BaseProps {
* any of the `Images` component of the Map.
*/
onImageMissing?(imageKey: string): void;

id?: string;
children: ReactElement;

children?: ReactElement;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/components/MapView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ interface MapViewProps extends BaseProps {
*/
regionDidChangeDebounceTime?: number;

children: ReactNode;
children?: ReactNode;
}

type Fn = (...args: any) => any;
Expand Down

0 comments on commit 1e35bf6

Please sign in to comment.