Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close resources #3292

Merged
merged 9 commits into from
Jun 11, 2024
Merged

Close resources #3292

merged 9 commits into from
Jun 11, 2024

Conversation

sebr72
Copy link
Contributor

@sebr72 sebr72 commented May 22, 2024

To ensure a resource is closed/freed when no longer used.

sbrunner
sbrunner reviewed May 22, 2024
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As resource you speak about the timer?
For me, it's not a resource, it just uses the same interface to be able to use in a try :-)

core/src/main/java/org/mapfish/print/map/tiled/CoverageTask.java Show resolved Hide resolved
@sebr72 sebr72 force-pushed the CloseResources branch 2 times, most recently from ccad793 to 69ef138 Compare May 22, 2024 16:02
@sebr72 sebr72 force-pushed the CloseResources branch 2 times, most recently from 983756c to 1021045 Compare June 7, 2024 16:04
sbrunner
sbrunner reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment •
edited by sebr72

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mapfish/mapfish-print/blob/master/core/src/main/java/org/mapfish/print/servlet/job/Accounting.java#L54C7-L54C39 => close ?

It is using the stop() method inside onJobSuccess()

core/src/main/java/org/mapfish/print/processor/ProcessorGraphNode.java Show resolved Hide resolved
core/src/main/java/org/mapfish/print/processor/ProcessorGraphNode.java Outdated Show resolved Hide resolved
@sebr72 sebr72 marked this pull request as ready for review June 11, 2024 16:04
@sebr72 sebr72 merged commit 8ed7bf5 into master Jun 11, 2024
10 checks passed
@sebr72 sebr72 deleted the CloseResources branch June 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebr72 @sbrunner