Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for global padding in popup auto-anchoring #11846

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewharvey
Copy link
Collaborator

@andrewharvey andrewharvey commented May 4, 2022

Launch Checklist

  • briefly describe the changes in this PR
    Popup auto anchoring will now account for the map padding.

  • include before/after visuals or gifs if this PR includes visual changes

before:
2022-05-04_15-58

after:
2022-05-04_15-57

  • write tests for all new functionality

TODO

  • document any changes to public APIs
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

closes #11841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup auto-anchoring should account for global padding
1 participant