fix: Patch dummylogin
vulnerability
#695
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The quetz API offers a
dummy_login
endpoint for development purposes. This endpoint allows a developer to bypass the authentication layer.Unfortunately, quetz doesn't take any measure to prevent an unauthorized third party from using that endpoint in production.
Changes
To address this critical vulnerability, I propose to to only expose this endpoint to the API conditionally. For that, it makes sense to use the existing
dev
flag. To pass that into the API subprocess it is convenient to use a file configuration element instead of a cli flag. Therefore I propose to remove the clidev
flag and replace it with the config file equivalent.