Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Patch dummylogin vulnerability #695

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

robinholzi
Copy link

Motivation

The quetz API offers adummy_login endpoint for development purposes. This endpoint allows a developer to bypass the authentication layer.

Unfortunately, quetz doesn't take any measure to prevent an unauthorized third party from using that endpoint in production.

Changes

To address this critical vulnerability, I propose to to only expose this endpoint to the API conditionally. For that, it makes sense to use the existing dev flag. To pass that into the API subprocess it is convenient to use a file configuration element instead of a cli flag. Therefore I propose to remove the cli dev flag and replace it with the config file equivalent.

@janjagusch janjagusch added the bug Something isn't working label Apr 26, 2024
@robinholzi
Copy link
Author

@janjagusch I resolved all test failure now (except from test_download_remote_file_in_parallel). Locally this test is passing. Using the create-tables CI matrix variant it also passes in the CI, use-migrations makes problems though. As this test also failed on main I assume that it's not related to my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants