feat: Support pre-configured supertoken authentication #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 83.23% 83.18% -0.05%
==========================================
Files 79 79
Lines 6291 6304 +13
==========================================
+ Hits 5236 5244 +8
- Misses 1055 1060 +5 ☔ View full report in Codecov by Sentry. |
janjagusch
reviewed
Feb 12, 2024
janjagusch
reviewed
Feb 12, 2024
Co-authored-by: Jan-Benedikt Jagusch <[email protected]>
janjagusch
approved these changes
Feb 12, 2024
janjagusch
reviewed
Feb 12, 2024
Comment on lines
170
to
+172
| def assert_server_roles(self, roles: list, msg: Optional[str] = None): | ||
| if self.is_supertoken: | ||
| return "supertoken" |
There was a problem hiding this comment.
I don't like how we're sneaking the super token into the authorization layer here. But I also understand that anything more explicit would require big changes in the Quetz authentication and authorization model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to run automated CI tests on a dockerized version of quetz (deployed with helm/Kubernetes). To be able to use the API there without any real user (e.g. authenticated via GitHub) we would like to be able to define a supertoken in the TOML config. It should act as an initial technical service account.
This token does not have to support all API endpoints (that could depend on an actual user being present). However, it should at least support creating new "real users" with username/password authentication (in our case https://github.com/mamba-org/quetz-sql-authenticator).
Changes
Introduce a new config element
users.supertokenand allow theRulesclass to bypass this token in the server role assertions.