Add HEAD authorization tests #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivergara
approved these changes
Nov 13, 2023
| @@ -439,20 +439,23 @@ def test_private_channels_download(db, client, data, channel_dirs): | |||
| assert response.text == "file content 0" | |||
|
|
|||
| # fail on private channel without credentials | |||
| response = client.get('/get/privatechannel/noarch/current_repodata.json') | |||
| assert response.status_code == 401 | |||
| for method in [client.get, client.head]: | |||
There was a problem hiding this comment.
@jonashaag, what would speak against adding a method callable as a parametrization instead of adding an iteration on each assertion?
There was a problem hiding this comment.
That was my first approach. The problem is that you need this in very few places only
|
Looks good to me, but I assume we're waiting for some more tests @jonashaag ? |
|
Are there any tests for package downloads? I haven't found them. I'd like to add the same there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make sure that
HEADrequests respond with 40x iff the correspondingGETrequests respond with 40x.I didn't find any tests for the actual package URLs. I'd like to add tests for those URLs as well.