Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Restructure docs configuration file and improve docs pages #3615

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

mathbunnyru
Copy link
Contributor

No description provided.

Comment on lines +32 to +34
# The file above was generated using sphinx 8.1.3 with this command:
# sphinx-quickstart --project "mamba" --author "QuantStack & mamba contributors" -v "latest" -r "latest" -l en --no-sep --no-makefile --no-batchfile
# These are custom options for this project
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows to have really simple configuration file for understanding, where you can easily see, which part of the docs is the standard config, and which is custom for this project.

Updating to new sphinx versions becomes easier and overall we have better distinction between generated code and handwritten.

Comment on lines +41 to +46
"path_to_docs": "docs/source",
"repository_branch": "main",
"repository_url": "https://github.com/mamba-org/mamba",
"use_download_button": True,
"use_edit_page_button": True,
"use_issues_button": True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few nice options here, which add a few buttons under GitHub logo and also make issues links more beautiful (if there will be any)


# Configure links which should be ignored during linkcheck
linkcheck_ignore = [
r".*github\.com.*#", # javascript based anchors
Copy link
Contributor Author

@mathbunnyru mathbunnyru Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Readme files have javascript based anchors, which causes linkcheck errors. I also fixed 2 redirect warnings below.
Now, docs links are correct (and maybe I will add a CI step later in a separate PR)

@jjerphan jjerphan added the release::ci_docs For PRs related to CI or documentation label Nov 21, 2024
@mathbunnyru
Copy link
Contributor Author

@jjerphan any chance to merge this?

@jjerphan
Copy link
Member

jjerphan commented Dec 4, 2024

I think that it would be appropriate activating the rendering of Pull Requests' documentation rendering first, i.e. what you proposed with #3598.

@JohanMabille
Copy link
Member

It looks like I don't have the permission to do that, so I would be in favor of merging this PR.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mathbunnyru.

@jjerphan jjerphan merged commit b6150db into mamba-org:main Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::ci_docs For PRs related to CI or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants