Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed restoring the previous signal handler for example in python case (Windows only for now) #3297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Klaim
Copy link
Member

@Klaim Klaim commented May 16, 2024

Should fix #3271 partially.

@Klaim Klaim added the release::bug_fixes For PRs fixing bugs label May 16, 2024
@Klaim
Copy link
Member Author

Klaim commented May 16, 2024

Trying to fix the linux case that still doesnt work.

@Klaim Klaim force-pushed the klaim/default-signal-handler branch from 860a861 to 6732f9c Compare June 19, 2024 11:09
@Klaim Klaim changed the title Fixed restoring the previous signal handler for example in python case Fixed restoring the previous signal handler for example in python case (Windows only for now) Jun 19, 2024
@Klaim
Copy link
Member Author

Klaim commented Jun 19, 2024

We'll try to get this merged to at least fix the Windows case, the non-working Linux case can be done in another PR

@Klaim Klaim force-pushed the klaim/default-signal-handler branch from 6732f9c to 659eeff Compare June 19, 2024 11:26
@@ -5,6 +5,7 @@
// The full license is in the file LICENSE, distributed with this software.

#include <atomic>
#include <iostream>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A leftover still left :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@Klaim Klaim force-pushed the klaim/default-signal-handler branch from 8f16629 to 9b048a5 Compare June 19, 2024 14:30
@Klaim Klaim force-pushed the klaim/default-signal-handler branch from 9b048a5 to 1ecaf68 Compare June 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2: Ctrl+C / SIGINT / KeyboardInterrupt handling not working
2 participants