Fix #2271, 2nd attempt #2305
Draft
Fix #2271, 2nd attempt #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashaag
commented
Feb 17, 2023
| @@ -72,6 +67,10 @@ def keep_in_path( | |||
| path_list = [p for p in path_list if keep_in_path(p)] | |||
| os.environ["PATH"] = os.pathsep.join(path_list) | |||
|
|
|||
| saved_environ = os.environ.copy() | |||
There was a problem hiding this comment.
The previous impl did not restore PATH. I assumed that to be a mistake and fixed the code accordingly.
Hind-M
reviewed
Feb 20, 2023
| saved_environ = {} | ||
| for k, v in os.environ.items(): | ||
| if k.startswith(("CONDA", "_CONDA", "MAMBA", "_MAMBA")): | ||
| saved_environ[k] = v |
There was a problem hiding this comment.
I guess this should not be removed since it's used below in:
def keep_in_path(
p: str, prefix: str | None = saved_environ.get("CONDA_PREFIX")
There was a problem hiding this comment.
Good catch, forgot to commit a change that changes this to os.environ.get("CONDA_PREFIX")
2 tasks
|
Actually the test is supposed to fail 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far adds a failing test.
cc @wolfv @Hind-M