Add dev mode command for micromamba shell init #2118
Conversation
| shell_hook_command | ||
| = "eval \"$(micromamba shell hook --shell=" + guessed_shell + ")\""; | ||
|
|
||
| shell_hook_dev_mode_cmd = "eval \"$(./micromamba/micromamba shell hook --shell=" |
There was a problem hiding this comment.
Won't this path change depending on user? It's not uncommon to put it under build/
There was a problem hiding this comment.
In my experience, I also don't need to run the hook again. Since the hook already uses the MAMBA_EXE variable, I can set export MAMBA_EXE="${PWD}/build/micromamba/micromamba. Or perhaps I'm missing something.
There was a problem hiding this comment.
Won't this path change depending on user? It's not uncommon to put it under
build/
If you are testing your built micromamba, I assumed you're in your build directory and so the path would be the same. But we could also make it ./build/micromamba/micromamba, maybe that would be clearer.
There was a problem hiding this comment.
In my experience, I also don't need to run the hook again. Since the hook already uses the
MAMBA_EXEvariable, I can setexport MAMBA_EXE="${PWD}/build/micromamba/micromamba. Or perhaps I'm missing something.
Well I don't know, maybe I am missing something... Because I had this info from Johan and it didn't work for me... We should probably need to discuss this.
| if (guessed_shell != "cmd.exe") | ||
| { | ||
| shell_hook = unindent((R"( | ||
|
|
||
| To initialize the current )" | ||
| + guessed_shell + R"( shell, run: | ||
| $ )" + shell_hook_command | ||
| + R"( | ||
| + shell_hook_dev_mode + R"( |
There was a problem hiding this comment.
This is going to be shown to all (non-dev) users? If so I would suggest a better approach would be to put that information in the docs.
There was a problem hiding this comment.
This is going to be shown to all (non-dev) users?
Yes.
If so I would suggest a better approach would be to put that information in the docs.
Well I thought about it but since the problem occurred while trying to activate an env with the built micromamba, I had this message error (which wasn't solving the problem). So I think that having an error message with the right suggested command would really help because it's the first thing that I/someone would try (follow the suggestion, before searching in the docs), but that doesn't mean not putting it there as well.
|
Thanks for publishing this @Hind-M. I also struggled with this at first, so this information should definitely go somewhere. My personal preference would be to not show this message to end users, whether it is putting it in the doc, or deactivating it with some sort of flag (is there a debug flag in |
Following my experience in dev mode to activate an environment using a locally built micromamba, I added the working command in the displayed error message to hopefully make it clearer.