Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings URL for plasma 6 #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix settings URL for plasma 6 #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/plugin/inputmethod.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,8 @@ void InputMethod::showSystemSettings()

if (qEnvironmentVariable("PLASMA_PLATFORM").contains(QStringLiteral("phone"))) {
QDesktopServices::openUrl(QUrl("systemsettings://kcm_mobile_onscreenkeyboard"));
} else if (qEnvironmentVariable("KDE_SESSION_VERSION").contains(QStringLiteral("6"))) {
QDesktopServices::openUrl(QUrl("systemsettings://kcm_regionandlang"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. The KCM for configuring Maliit is only for Plasma Mobile. The normal Layouts config in Plasma is only for physical keyboards, not Maliit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, is there any relevant page in desktop Plasma settings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not, as far as I know. I think the kcm_mobile_onscreenkeyboard for Plasma Mobile is also wrong now, as someone decided to change the name of the kcm yet again, in KDE, though. So simply changing it to the correct new value would be accepted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing a quick search kcm_mobile_onscreenkeyboard still seems to be used in Plasma Mobile. Unfortunately I got no easy way of verifying this, as I do not use Plasma Mobile. One more idea - how about opening kcm_virtualkeyboard as that is at least somewhat relevant? (not very useful though)

} else {
QDesktopServices::openUrl(QUrl("settings://system/language"));
}
Expand Down