-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no issue - configuration changes and old names deprecation #191
Conversation
d0b8056
to
a252b57
Compare
src/Bridge/Symfony/DependencyInjection/DbToolsConfiguration.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me thanks 👍
src/Bridge/Symfony/DependencyInjection/DbToolsConfiguration.php
Outdated
Show resolved
Hide resolved
Just may be you can update sample config file to put at the top of the file config that users will want to edit the most. Like But, not sure about that, I let you choose if this is a good idea or not ! |
a252b57
to
025a7d2
Compare
028a896
to
d741b85
Compare
d741b85
to
4b63321
Compare
# configuration into multiple files, you can directly write it here. | ||
# If you do not wish to split the configuration into tables, you can | ||
# write all your table configuration directly here. | ||
# Keys are connection names, values must follow the structure of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there's only one connection, what's its name ?
does the 'connection' stage needed ? if not, may be you can omit this part and just redirect to the doc for a multiconnection setup
May be for the standalone version, we can simplify the anonymization declaration like this:
Seems easier to understand and to use |
6a91a2f
to
7b05108
Compare
7b05108
to
79efa91
Compare
Failure was a random MySQL float error, I merged anyway. |
Variant of #162