-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to customize TTL in mailinabox.conf. #1965
base: main
Are you sure you want to change the base?
Conversation
Why is this |
It's |
Ok, I see the logic for that now. Thanks. I suppose I incorrectly assumed the /etc/mailinabox.conf variables could be passed by environment variables before setup to set them. I guess my assumption is wrong (or that maybe only some of them could be set that way). Looks like it will set TTL=86400 when no TTL=... exists in /etc/mailinabox.conf and does keep a custom value on additional run. Now I need to go back and look at MTA_STS_MODE to see if it does what I think it does... (edit: it doesn't; i'll need to raise an issue for it) |
Yes, that's the plan. To make it a bit easier to change the value without messing things up, I would suggest helper scripts in the tools folder to set the TTL to 5 minutes (old default) and 1 day (new default). If it increases the chance for a merge, I would be happy to add these scripts. |
Editing a text file sounds reasonable, reduces maintenance requirement by not having additional scripts. |
I'll give this a test here in a bit, I personally prefer short ttl's. |
I did not read your reply before adding the scripts. I'm fine leaving them out. |
Will this change be implemented in the dashboard interface? I suspect there will be regular issues for new users who have not previously configured DNS records, so they will be making mistakes and wanting to see their changes and corrections sooner than a day or two after making the change. |
Good point! I would appreciate such an option in the user interface but the implementation is way too complex for me. |
Running fine with TTL=1800 |
Not want to nit pick, but your script name tools/set_ttl_to_5_minutes.sh sets the TTL to 1800, which is 30 minutes...not 5 as the script name suggests |
I think the The script titled |
Is anyone experiencing any issues with this PR? Has @User1000001 abandoned it? |
No, I haven't abandoned the PR. I'm just pretty busy currently. Sorry I did not reply earlier. Honestly, I have no idea what the settings actually do. I just noticed that my system did not work anymore with the new settings and tried to fix it. |
Is the configuration in this PR still working for you right now? |
In case I wasn't very clear, the |
OK, I fixed the retry value. And yes, the configuration works for me. |
Are there any plans to merge this pull request? |
Hi. I'd need you to make a few changes before I would consider merging this PR:
|
Is it enough to explain that the default TTL is set as 1 day (86400 seconds) and that it can be adjusted by modifying I mean, for any user who doesn't understand what TTL is for, they should not be touching this value. Make sense? |
As discussed here, it seems to be necessary to reduce the time-to-live in order to use miab as dyndns for frequently changing IPs. This became apparent after changing the TTL from 1800 seconds to 86400 seconds (1 day). In the discussion of the pull-request that made this change, the idea was mentioned to make the TTL persistently customizable in
mailinabox.conf
. This pull-request attempts to realize this idea.