Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use license_files instead of license_file in setup.cfg #357

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Nov 29, 2023

Use license_files instead

Use license_files instead
@bkmgit
Copy link
Contributor Author

bkmgit commented Nov 29, 2023

@mahmoud
Copy link
Owner

mahmoud commented Nov 29, 2023

Interesting, though that link doesn't specify that license_file is deprecated, just that it has a new alias. Is there another source you can point me to? Can you elaborate on why we'd introduce an implicit minimum version of setuptools (42.0.0)?

@mahmoud mahmoud changed the title license_file is deprecated Use license_files instead of license_file in setup.cfg Nov 29, 2023
@bkmgit
Copy link
Contributor Author

bkmgit commented Nov 30, 2023

This is a warning that came up when building for inclusion on Fedora linux. See the log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252017-python-boltons/fedora-rawhide-x86_64/06705253-python-boltons/builder-live.log.gz

Is there a good way to support multiple versions of setuptools/python?

@mahmoud
Copy link
Owner

mahmoud commented Nov 30, 2023

Got it, thanks for the log. I've opened an issue on setuptools to update their docs: pypa/setuptools#4147

As for version management, I think we're ok to upgrade. I looked up the setuptools version and any version released after 2019 should be fine. We could add setuptools>42 or something to setup_requires, but that'd mostly be as a form of documentation.

@mahmoud mahmoud merged commit 47c8046 into mahmoud:master Dec 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants