Use roave/better-reflection to guess packages

composer.json

@@ -31,6 +31,7 @@
         "ext-phar": "*",
         "composer-runtime-api": "^2.0.0",
         "nikic/php-parser": "^4.13.0",
+        "roave/better-reflection": "^5.0",
         "symfony/console": "^6.0.0",
         "webmozart/assert": "^1.9.1",
         "webmozart/glob": "^4.4.0"

infection.json.dist

@@ -5,7 +5,7 @@
             "src"
         ]
     },
-    "timeout": 30,
+    "timeout": 60,
     "logs": {
         "text": "php://stderr"
     },

src/ComposerRequireChecker/Cli/CheckCommand.php

@@ -12,6 +12,8 @@
 use ComposerRequireChecker\DefinedSymbolsLocator\LocateDefinedSymbolsFromComposerRuntimeApi;
 use ComposerRequireChecker\DefinedSymbolsLocator\LocateDefinedSymbolsFromExtensions;
 use ComposerRequireChecker\DependencyGuesser\DependencyGuesser;
+use ComposerRequireChecker\DependencyGuesser\GuessFromInstalledComposerPackages;
+use ComposerRequireChecker\DependencyGuesser\GuessFromLoadedExtensions;
 use ComposerRequireChecker\Exception\InvalidJson;
 use ComposerRequireChecker\Exception\NotReadable;
 use ComposerRequireChecker\FileLocator\LocateComposerPackageDirectDependenciesSourceFiles;
@@ -212,7 +214,11 @@ public function __invoke(string $string): void
                 $resultsWriter = new CliText($output);
         }
 
-        $guesser = new DependencyGuesser($options);
+        $guesser = new DependencyGuesser([
+            new GuessFromLoadedExtensions($options),
+            new GuessFromInstalledComposerPackages(dirname($composerJson)),
+        ]);
+
         $resultsWriter->write(
             array_map(
                 static function (string $unknownSymbol) use ($guesser): array {

src/ComposerRequireChecker/DependencyGuesser/DependencyGuesser.php

@@ -4,17 +4,19 @@
 
 namespace ComposerRequireChecker\DependencyGuesser;
 
-use ComposerRequireChecker\Cli\Options;
 use Generator;
 
 class DependencyGuesser
 {
-    /** @var Guesser[] */
+    /** @var array<Guesser> */
     private array $guessers = [];
 
-    public function __construct(?Options $options = null)
+    /**
+     * @param array<Guesser> $guessers
+     */
+    public function __construct(array $guessers)
     {
-        $this->guessers[] = new GuessFromLoadedExtensions($options);
+        $this->guessers = $guessers;
     }
 
     /**

src/ComposerRequireChecker/DependencyGuesser/GuessFromInstalledComposerPackages.php

@@ -0,0 +1,93 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ComposerRequireChecker\DependencyGuesser;
+
+use ComposerRequireChecker\JsonLoader;
+use Generator;
+use Roave\BetterReflection\BetterReflection;
+use Roave\BetterReflection\Identifier\Identifier;
+use Roave\BetterReflection\Identifier\IdentifierType;
+use Roave\BetterReflection\Reflection\ReflectionClass;
+use Roave\BetterReflection\Reflection\ReflectionConstant;
+use Roave\BetterReflection\Reflection\ReflectionFunction;
+use Roave\BetterReflection\Reflector\DefaultReflector;
+use Roave\BetterReflection\SourceLocator\Type\Composer\Factory\MakeLocatorForInstalledJson;
+use Roave\BetterReflection\SourceLocator\Type\MemoizingSourceLocator;
+use Roave\BetterReflection\SourceLocator\Type\SourceLocator;
+
+use function preg_match;
+use function preg_quote;
+use function sprintf;
+use function str_replace;
+
+use const DIRECTORY_SEPARATOR;
+
+final class GuessFromInstalledComposerPackages implements Guesser
+{
+    private SourceLocator $sourceLocator;
+    private string $pathRegex;
+
+    public function __construct(string $installationPath)
+    {
+        $this->sourceLocator = new MemoizingSourceLocator((new MakeLocatorForInstalledJson())(
+            $installationPath,
+            (new BetterReflection())->astLocator()
+        ));
+
+        $cleanPath       = preg_quote(sprintf('%s/vendor', str_replace(DIRECTORY_SEPARATOR, '/', $installationPath)), '@');
+        $this->pathRegex = sprintf('@^%s/(?:composer/\.\./)?([^/]+/[^/]+)/@', $cleanPath);
+    }
+
+    /**
+     * @return Generator<string>
+     */
+    public function __invoke(string $symbolName): Generator
+    {
+        foreach ($this->locateIdentifier($symbolName) as $reflection) {
+            $path = $reflection->getFileName();
+
+            if ($path === null) {
+                continue;
+            }
+
+            $matched = preg_match($this->pathRegex, $path, $captures);
+
+            if (! $matched) {
+                continue;
+            }
+
+            yield JsonLoader::getData($captures[0] . 'composer.json')['name'];
+        }
+    }
+
+    /**
+     * @return Generator<ReflectionClass|ReflectionFunction|ReflectionConstant>
+     */
+    private function locateIdentifier(string $symbolName): Generator
+    {
+        $locatedIndentifiers = [
+            $this->sourceLocator->locateIdentifier(
+                new DefaultReflector($this->sourceLocator),
+                new Identifier($symbolName, new IdentifierType(IdentifierType::IDENTIFIER_CLASS))
+            ),
+            $this->sourceLocator->locateIdentifier(
+                new DefaultReflector($this->sourceLocator),
+                new Identifier($symbolName, new IdentifierType(IdentifierType::IDENTIFIER_FUNCTION))
+            ),
+            $this->sourceLocator->locateIdentifier(
+                new DefaultReflector($this->sourceLocator),
+                new Identifier($symbolName, new IdentifierType(IdentifierType::IDENTIFIER_CONSTANT))
+            ),
+        ];
+
+        foreach ($locatedIndentifiers as $locatedIndentifier) {
+            if (! ($locatedIndentifier instanceof ReflectionFunction || $locatedIndentifier instanceof ReflectionClass || $locatedIndentifier instanceof ReflectionConstant)) {
+                continue;
+            }
+
+            yield $locatedIndentifier;
+        }
+    }
+}

test/ComposerRequireCheckerTest/Cli/CheckCommandTest.php

@@ -206,12 +206,14 @@ public function testSourceFileThatUsesDevDependency(): void
             'composer-json' => dirname(__DIR__, 3) . '/composer.json',
             '--config-file' => $root->getChild('config.json')->url(),
         ]);
-
         $this->assertNotEquals(0, $exitCode);
-        $this->assertMatchesRegularExpression(
-            '/The following 2 unknown symbols were found.*PHPUnit\\\\Framework\\\\TestCase/s',
-            $this->commandTester->getDisplay()
-        );
+
+        $display = $this->commandTester->getDisplay();
+        $this->assertStringContainsString('The following 2 unknown symbols were found', $display);
+        $this->assertStringContainsString('org\bovigo\vfs\vfsStream', $display);
+        $this->assertStringContainsString('mikey179/vfsstream', $display);
+        $this->assertStringContainsString('PHPUnit\Framework\TestCase', $display);
+        $this->assertStringContainsString('phpunit/phpunit', $display);
     }
 
     public function testNoUnknownSymbolsFound(): void