Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPDOC] Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface #39199

Open
wants to merge 10 commits into
base: 2.4-develop
Choose a base branch
from
20 changes: 5 additions & 15 deletions lib/internal/Magento/Framework/App/Config.php
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php
/**
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2013 Adobe
* All Rights Reserved.
*/

namespace Magento\Framework\App;

use Magento\Framework\App\Config\ConfigTypeInterface;
Expand Down Expand Up @@ -45,12 +45,7 @@ public function __construct(
}

/**
* Retrieve config value by path and scope
*
* @param string $path
* @param string $scope
* @param null|int|string $scopeCode
* @return mixed
* @inheritDoc
*/
public function getValue(
$path = null,
Expand Down Expand Up @@ -80,12 +75,7 @@ public function getValue(
}

/**
* Retrieve config flag
*
* @param string $path
* @param string $scope
* @param null|int|string $scopeCode
* @return bool
* @inheritDoc
*/
public function isSetFlag($path, $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null)
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<?php
/**
* Configuration interface
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2011 Adobe
* All Rights Reserved.
*/

namespace Magento\Framework\App\Config;
Expand All @@ -17,14 +15,14 @@ interface ScopeConfigInterface
/**
* Default scope type
*/
const SCOPE_TYPE_DEFAULT = 'default';
public const SCOPE_TYPE_DEFAULT = 'default';

/**
* Retrieve config value by path and scope.
*
* @param string $path The path through the tree of configuration values, e.g., 'general/store_information/name'
* @param string $scopeType The scope to use to determine config value, e.g., 'store' or 'default'
* @param null|int|string $scopeCode
* @param null|int|string|\Magento\Store\Api\Data\StoreInterface $scopeCode
dimitriBouteille marked this conversation as resolved.
Show resolved Hide resolved
* @return mixed
*/
public function getValue($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null);
Expand All @@ -34,7 +32,7 @@ public function getValue($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DE
*
* @param string $path The path through the tree of configuration values, e.g., 'general/store_information/name'
* @param string $scopeType The scope to use to determine config value, e.g., 'store' or 'default'
* @param null|int|string $scopeCode
* @param null|int|string|\Magento\Store\Api\Data\StoreInterface $scopeCode
dimitriBouteille marked this conversation as resolved.
Show resolved Hide resolved
* @return bool
*/
public function isSetFlag($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null);
Expand Down