-
Notifications
You must be signed in to change notification settings - Fork 154
Release
Marc Ginesta edited this page Oct 5, 2022
·
14 revisions
In order to avoid broken builds in the Magento ecosystem and major issues, we would like to check the magento-coding-standard
against magento2ce
and magento2ee
prior to the release.
The following instructions work for both magento2ce
and magento2ee
.
First of all, you'll need to get the latest changes from develop branch git pull origin 2.4-develop
([email protected]:magento-commerce/magento2*e.git
).
Then, you'll need to update the composer.json
file as follows:
{
...
"require-dev": {
...
"magento/magento-coding-standard": "dev-[branch]"
...
}
...
"minimum-stability": "dev",
"repositories": [
{
"type": "git",
"url": "https://github.com/[fork]/magento-coding-standard"
}
]
}
Notes:
-
fork
: your own fork ormagento
if you have already merged your changes -
branch
: in case changes are not merged it will be your development branch, otherwisedevelop
Now, you need to follow these steps:
- Open a PR (for both repos) and run tests using
@magento run all tests
(write it as a comment on themagento2ce
PR) - If static tests fail 🔴 , then you need to perform changes in your code and you should not merge changes to
master
branch - If tests all tests are green 🟢 (specifically, we need Static tests to be green) you can proceed with the release
- Open a PR for
magento-coding-standard
repo and merge your branch todevelop
if you haven't done this already - Create a new branch from
develop
(i.e.,release-vN
) - Increment the version in
composer.json
- Run
composer update
to update thecomposer.lock
- Open a PR on
magento-commerce/magento-coding-standard
and merge it todevelop
branch - Merge
develop
branch tomaster
branch creating a new PR onmagento-commerce/magento-coding-standard
- Create a new release on Github
- Ensure the new version is available in packagist
- 📢 Notify the #coding-standard channel (from the Magento Open Source workspace)
- Update
composer.lock
formagento-commerce/magento2ce
andmagento-commerce/magento2ee
runningcomposer update magento/magento-coding-standard
- Open a PR (for both repos) and run tests
@magento run all tests
- ☑️ Make sure that all tests are green 🟢 (they should be green since you did not perform further changes)
- You'll need to update
composer.json
for other repos such asmagento-api-index
,mray
anduct
. We needmagento-coding-standard
pointing to the newest release. - Update
composer.lock
for each repo you required by runningcomposer update magento/magento-coding-standard
- Open a PR for each repo you have updated and merge changes to develop