Removing dependency on symfony/polyfill, is no longer required now th…

[hostep]

…at we dropped support for PHP 7.4

Fixes #467

As explained in the issue, the symfony/polyfill dependency got added in 2ea3c39 for the use of the php function str_starts_with which was added in PHP 8.0, at that time, the coding-standards repository still supported PHP 7.4, so it made sense at the time to add a polyfill.
However, since 8d37ab7 support for PHP 7.4 was dropped. So this polyfill package is no longer needed.

I'd say, merge this and tag a new version 33 of coding-standards, so people using Magento aren't being forced to install the entire symfony/polyfill package which comes with a whole lot of extra code that's not needed, maybe it will even cause a slight performance impact if all that code gets potentially loaded inside a Magento application.

[fredden]

Thanks for putting this together @hostep. I agree this can be safely removed. The coding standard should be installed as a development dependency though, so shouldn't cause any performance impact on production.

[hostep]

@fredden: that's not exactly true, dependencies of dev-dependencies can influence production dependencies being installed.
See the output in composer/composer#11641, by upgrading to v32 of coding-standards, it replaces the individual polyfill packages with the full one, and that one gets stored in the composer.lock file, so it gets installed in production as well.

I'm not a super fan of how dev dependencies work in composer, I've been experimenting with https://github.com/bamarni/composer-bin-plugin for over a year in some modules I've built (example), for better seperation of dev & prod composer dependencies so they don't influence each other as much, and I quite like it. It doesn't work with everything, I believe phpunit and composer-normalize can't be used without problems this way, but most dev dependencies (phpcs, php-cs-fixer, phpstan, ...) can be used without issues like this.

[sidolov]

@magento import pr to magento-commerce/magento-coding-standard repository

[m2-github-services]

@sidolov the Pull Request is successfully imported.

[fredden]

@sidolov please can we get a new release which includes this change?

[hostep]

Got released in v33 today 🎉