Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Packages #745

Merged
merged 22 commits into from
Mar 13, 2020
Merged

Update Packages #745

merged 22 commits into from
Mar 13, 2020

Conversation

KingDarBoja
Copy link
Collaborator

@KingDarBoja KingDarBoja commented Dec 28, 2019 •
edited
Loading

This is a WIP. This include several features, bugfixes and enhancements for all @ng-toolkit packages.

Features

Utils

  • Add new functions to parse yml files to JS and viceversa. Useful for editing the serverless.yml file as example.

Serverless

  • lambdaTS and offline options to generate lambda typescript files and run locally any AWS API Gateway endpoint.

IMPORTANT NOTE For some reason, I haven't found a way to make serverless-offline properly load the assets and compiled js files on the index while serving offline. So this feature is not fully complete.

Universal

Bugfixes

Universal

The prerendering script does work now with the new lazy loading syntax, however, it can't find nested routes from these modules. Due to the complexity of this script, it shall be removed on the v9 version of this package as upcoming angular/universal package (v9) will ship with a new prerendering builder which is way easier to use.

This was included on v8 of the universal express engine package but is no longer need on upcoming v9.

PWA

  • No longer needs the @ng-toolkit/universal package.

The @ng-toolkit/pwa didn't really make use of the universal package, it was being included due to testing purposes but wasn't critical to have it.

Dependencies

  • Use cpy-cli package instead of cp-cli package.

_The cp-cli package got out of maintenance and the author released a brand new one called cpy-cli.

  • Add js-yaml package to process yml <-> js files.

Awesome package to handle the serverless yml file without relying on duplicating the same file to include some small changes.

Also I think the @ng-toolkit/_utils package should be renamed into @ng-toolkit/utils.

@KingDarBoja KingDarBoja added comp: serverless Serverless Package comp: universal Universal Package comp: pwa PWA Package comp: _utils Utils package labels Dec 28, 2019
@KingDarBoja KingDarBoja added this to the 8.1.0 milestone Dec 28, 2019
@KingDarBoja KingDarBoja self-assigned this Dec 28, 2019
@KingDarBoja
chore(pwa): remove universal dependency
08e93f9
@KingDarBoja
refactor(pwa): create functions per rules
8ac2951
@KingDarBoja
fix(_utils): return dependency injection param
4ac72da
@KingDarBoja
chore(pwa): use cpy-cli instead of cp-cli package
bdf60c0
@KingDarBoja
chore(universal): several bugfixes and enhancements
066de84 
- Added rule to generate robots.txt file
- Fix prerender script
- Comment the externals after applying angular/universal schematic
@KingDarBoja
fix(pwa): cpy script
3bdebee
@KingDarBoja
fix(serverless): remove previous lambda ts file
20d9354
@KingDarBoja
fix(universal): remove leading slash on source root function
8850aea
@KingDarBoja
fix(universal): externals webpack line
97e8d43
@KingDarBoja
fix(universal): rule to modify tsconfig options
1a5e5b5
@KingDarBoja
fix(universal): cpy output folder paths
06187da
@KingDarBoja
fix(pwa): cpy output paths
507f424
@KingDarBoja
refactor(firebug): rules into functions
bbac557
@KingDarBoja
chore(firebug): Update dependencies and bump version
f30e98e
@KingDarBoja KingDarBoja mentioned this pull request Dec 30, 2019
Closed
@KingDarBoja KingDarBoja added comp: firebug Firebug Package comp: init Init Package labels Dec 30, 2019
@KingDarBoja KingDarBoja mentioned this pull request Dec 31, 2019
Open
@KingDarBoja KingDarBoja mentioned this pull request Jan 8, 2020
Open
@KingDarBoja KingDarBoja marked this pull request as ready for review February 24, 2020 16:39
@KingDarBoja KingDarBoja merged commit b8e5b70 into maciejtreder:master Mar 13, 2020
@KingDarBoja KingDarBoja deleted the bugfix/core-patch-dec branch March 13, 2020 14:12
@KingDarBoja KingDarBoja changed the title [WIP] Update Packages Update Packages Mar 13, 2020
@KingDarBoja KingDarBoja mentioned this pull request Mar 13, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejtreder maciejtreder Awaiting requested review from maciejtreder

Assignees

@KingDarBoja KingDarBoja

Labels
comp: firebug Firebug Package comp: init Init Package comp: pwa PWA Package comp: serverless Serverless Package comp: universal Universal Package comp: _utils Utils package
Projects
None yet
Milestone
8.1.0
1 participant
@KingDarBoja