Skip to content

Commit

Permalink
Doc update: swap legacy browser names (#66)
Browse files Browse the repository at this point in the history
* Update old browser references
  • Loading branch information
twistedpair authored Jan 10, 2025
1 parent 279055e commit ff01375
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
[curl builder](https://app.mabl.com/workspaces/-/settings/apis#api-docs-selector-dropdown-button)
to find the id.
- `browser-types` {string} (optional): comma or new line separated override for browser
types to test e.g. `chrome, firefox, safari, internet_explorer`. If not
types to test e.g. `chrome, firefox, webkit, edge`. If not
provided, mabl will test the browsers configured on the triggered test.
- `plan-labels` {string} (optional): comma or new line separated plan labels to test. Plans matching **any** label will be run. e.g. `smoke-test, beta-feature`. Note: additional selection criteria must also be met like application-id or environment-id, if supplied.
- `uri` {string} (optional, DEPRECATED - use app_url) the base uri to run browser based tests against. If provided, this will
Expand Down
8 changes: 4 additions & 4 deletions test/suite.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ describe('GitHub Action tests', () => {
setGithubInput(ActionInputs.BrowserTypes, 'chrome, firefox ');
expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox']);

setGithubInput(ActionInputs.BrowserTypes, 'chrome\nfirefox\nsafari ');
expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox', 'safari']);
setGithubInput(ActionInputs.BrowserTypes, 'chrome\nfirefox\nwebkit\nedge ');
expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox', 'webkit', 'edge']);
});

it('parses boolean inputs', () => {
Expand Down Expand Up @@ -123,7 +123,7 @@ describe('GitHub Action tests', () => {
environment_id: 'env',
application_id: 'app',
plan_overrides: {
browser_types: ['firefox', 'chrome', 'internet_explorer'],
browser_types: ['firefox', 'chrome', 'edge'],
web_url: 'fake-app-url',
api_url: 'fake-api-url',
},
Expand All @@ -145,7 +145,7 @@ describe('GitHub Action tests', () => {
};
const apiClient = new MablApiClient('test');
const requestBody = apiClient.buildRequestBody(
['firefox', 'chrome', 'internet_explorer'],
['firefox', 'chrome', 'edge'],
[],
[],
true,
Expand Down

0 comments on commit ff01375

Please sign in to comment.