Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wavrec appending the end of one recording to the next file #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wavrec appending the end of one recording to the next file #21

wants to merge 1 commit into from

Conversation

pmaanen
Copy link

@pmaanen pmaanen commented Feb 22, 2019

The problem with corrupted recording is probably a thread-safety
issue. In unixoid systems 'mv' is generally atomic while 'cp'
is not.

Fix wavrec appending the end of one recording to the next file
1654e13 
The problem with corrupted recording is probably a thread-safety
issue. In  unixoid systems 'mv' is generally atomic while 'cp'
is not.
@pmaanen pmaanen mentioned this pull request Feb 22, 2019
Closed
m-r-s
m-r-s reviewed Feb 27, 2019
View reviewed changes
Copy link
Owner

@m-r-s m-r-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will test it. The problem here is that some script rely on the last recording being available as "/dev/shm/recording.wav".
Would "sync" maybe help as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-r-s m-r-s m-r-s left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmaanen @m-r-s