aws: topology cache for aws s3 and iam resources #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecutalo
reviewed
May 21, 2024
There was a problem hiding this comment.
Hey @tolujimoh can we break this PR down into 3 parts so its easier to review? 1. Protos 2. backend aws bits 3. topology cache changes?
tolujimoh
force-pushed
the
topology-cache-s3-iam
branch
from
aa4b814
to
83e613f
Compare
Hey Mike. I have broken in down to 3 CRs Proto changes Backend changes Cache changes |
tolujimoh
force-pushed
the
topology-cache-s3-iam-backend
branch
from
9f70e9b
to
3291d2d
Compare
tolujimoh
force-pushed
the
topology-cache-s3-iam
branch
from
83e613f
to
245107c
Compare
tolujimoh
force-pushed
the
topology-cache-s3-iam
branch
from
245107c
to
637933f
Compare
mikecutalo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This CR add topology cache for the following aws resources
This cache is implemented to support autocomplete of aws resources for s3 access workflow
Backend changes
#3023
Proto changes
#3022