Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested transitions #30

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix nested transitions #30

merged 2 commits into from
Feb 15, 2023

Conversation

Razboy20
Copy link
Contributor

@Razboy20 Razboy20 commented Feb 9, 2023

Transition will now wait for all ChildTransition components underneath to finish transitioning before removing itself. This also fixes early transitionEnd calls by cancelling transition/animation event bubbling. (e.g. if you have a button that you hover over which causes a transition event, this would be accidentally listened to.)

@vercel
Copy link

vercel bot commented Feb 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
solid-headless ❌ Failed (Inspect) Feb 10, 2023 at 4:16PM (UTC)

@Razboy20
Copy link
Contributor Author

Razboy20 commented Feb 9, 2023

Should also fix #15.

@lxsmnsyc
Copy link
Owner

lxsmnsyc commented Feb 10, 2023

Thanks for making this PR! I would like to suggest one thing though: add comments. I know that I don't add it myself (to which I'll do in the foreseeable future) but the reason I would want comments is because I would like to know how this works myself too 🤣

Edit:
As a bonus, I think we could create another Transition example in the examples/ as some sort of early testing

@Razboy20
Copy link
Contributor Author

Added a couple comments/renamed some variables to hopefully improve the code readability.

Another transition example also sounds like a good idea-maybe might be good to create some more pages to the solid-headless website as well, or be able to view all the examples on there.

@lxsmnsyc
Copy link
Owner

solid-headless site itself is collecting dusts. I'll be recreating it from scratch again since I found an SSR setup I liked

@lxsmnsyc
Copy link
Owner

Okay I'll merge this now so I can test this locally, then we can fix whatever needs to be fixed onwards since this is better than me doing nothing for nested transitions 😅

@lxsmnsyc lxsmnsyc merged commit d249ec6 into lxsmnsyc:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants