-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renesas GLCDC dirver #6221
Renesas GLCDC dirver #6221
Conversation
|
0a95154
to
35501b4
Compare
Correct, normally we don't compile the hardware specific code. |
|
||
int32_t w = lv_area_get_width(area); | ||
int32_t h = lv_area_get_height(area); | ||
SCB_CleanInvalidateDCache_by_Addr(px_map, w * h * 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be called in line 204 for the frame buffer.
SCB_CleanInvalidateDCache_by_Addr(fb, DISPLAY_HSIZE_INPUT0 * DISPLAY_VSIZE_INPUT0 * 2);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replacing 191 or keep both? and why call for the whole buffer in partial mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only at line 191.
It would be more optimal to invalidate on the changed area. It can be added now or in a later PR as an optimization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested line does not work, as fb
is being incremented in the loop, and pointing to a bad location by line 204.
This works* at the end of function:
SCB_CleanInvalidateDCache_by_Addr(fb_background[1], sizeof(fb_background[1]));
Or this in the loop:
SCB_CleanInvalidateDCache_by_Addr(fb, w * 2);
However it only works for the artifacts seen at switch transition. Pressing the "Log out" button also creates artifacts and they are not resolved by cache invalidation. It might be a different issue, as the stripes are inside the button, with white color. At no point the animation should be that, so it's not a "slow transition" related to cache emptying out.
This is not present in direct mode, however a scroll bar appears after pressing the button once. The bar does not appear in the PC emulator with matching screen resolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just a few comments.
35501b4
to
1c63fba
Compare
1c63fba
to
1563b8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We can fix the issue of the partial rendering in a separate PR.
The failing CI is unrelated and being discussed here.
Please merge without squashing @kisvegabor |
Merged, thank you Akos! |
Add display driver to support Renesas GLCDC peripheral.