release 7.1.0 #13
release 7.1.0 #13
Conversation
Updates the dev rockspec to pin to a tag, such that new rockspecs generated from it will not point to `master` but to the version tag.
| license = "MIT/X11", | ||
| homepage = "https://github.com/lunarmodules/lua-iconv/" | ||
| homepage = "https://github.com/"..github_account_name.."/"..github_repo_name, |
There was a problem hiding this comment.
Is that generated ? I find this needlessly obscure.
There was a problem hiding this comment.
most of the lunar modules projects have this. I find it easier to manage since all essential metadata is at the top of the file now. (had too many cases of editing one but forgetting another occurrence).
Anyway, I do get your point, so let me know if the above doesn't change your mind, then I'll update it.
There was a problem hiding this comment.
Sometimes I like to open these uris from my editor, and this kind of interpolation breaks that. Overall I think this parameterization makes the rockspec harder to read and because it's generated, everything could be hardcoded instead.
But it's a minor annoyance, dont bother. Let's use the general workflow.
There was a problem hiding this comment.
I run into this a lot with distro packaging, especially in Arch Linux where package manifests are bash scripts and anything may be interpreted. I have some editor functions setup to do things like "open the homepage for this package" that process the language and use the output. For example in VIM, this can be done for almost any rockspec, including this one, like so:
:!sh -c "lua -e 'dofile [[%]] print(description.homepage)' | xdg-open"Obviously the nested quoting is tricky, but with Lua's extra quote types at hand and VIM expanding the % to the current buffer filename, this command when run while editing a rockspec will send the home page to my browser. I have it wrapped in a command that does different things for different file types, but it means I don't have to worry about all URLs being spelled out with no variables in them.
There was a problem hiding this comment.
nice tip, though the approach may scare contributors away.
masterbut to the version tag.